facebook / facebook/fresco

Tap on retry logic doesn't work if cache image is broken

Open
#906 2 comments 0 reactions 1 assignee Claimed by @defHLT View on GitHub
bug
Dominant language
Kotlin
Stars
17.2k
Forks
3.7k
PR merge metrics
No merged PRs in 30d

Description

Here are the steps I reproduce the issue:
1. Load an image with SimpleDraweeView e.g. (https://www.google.com.hk/logos/doodles/2016/charles-perraults-388th-birthday-5071286030041088-5656774724026368-ror.jpg)
2. Find out the cache file by this URL according to this http://stackoverflow.com/a/31610386/827785
3. I pull out the cache file, manually make it corrupted, push it back to the phone.
4. Now it will show the retry icon when the image is loaded.

However, when I tap on it, see the log:

```
V/unknown:AbstractDraweeController: controller 52a0b440 44: final_failed @ onFailure: failure: java.lang.IllegalArgumentException: unknown image format
```

Is this retry logic expected according to design? What I am expecting is that, it will try to clear the wrong cache, and download it again from network.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.