facebook / facebook/fresco

about a crash

Open
#2,832 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
17.2k
Forks
3.7k
PR merge metrics
No merged PRs in 30d

Description

#10325 FrescoDecodeExecutor-2

java.lang.IllegalArgumentException

width and height must be > 0

1
android.graphics.Bitmap.createBitmap(Bitmap.java:1042)
2
android.graphics.Bitmap.createBitmap(Bitmap.java:1009)
3
android.graphics.Bitmap.createBitmap(Bitmap.java:959)
4
android.graphics.Bitmap.createBitmap(Bitmap.java:920)
5
com.facebook.imagepipeline.animated.impl.AnimatedDrawableBackendImpl.prepareTempBitmapForThisSize(AnimatedDrawableBackendImpl.java:5)
6
com.facebook.imagepipeline.animated.impl.AnimatedDrawableBackendImpl.renderImageSupportsScaling(AnimatedDrawableBackendImpl.java:10)
7
com.facebook.imagepipeline.animated.impl.AnimatedDrawableBackendImpl.renderFrame(AnimatedDrawableBackendImpl.java:3)
8
com.facebook.imagepipeline.animated.impl.AnimatedImageCompositor.renderFrame(AnimatedImageCompositor.java:17)
9
com.facebook.fresco.animation.bitmap.wrapper.AnimatedDrawableBackendFrameRenderer.renderFrame(AnimatedDrawableBackendFrameRenderer.java:1)
10
com.facebook.fresco.animation.bitmap.preparation.DefaultBitmapFramePreparer$FrameDecodeRunnable.renderFrameAndCache(DefaultBitmapFramePreparer.java:2)
11
com.facebook.fresco.animation.bitmap.preparation.DefaultBitmapFramePreparer$FrameDecodeRunnable.prepareFrameAndCache(DefaultBitmapFramePreparer.java:14)
12
com.facebook.fresco.animation.bitmap.preparation.DefaultBitmapFramePreparer$FrameDecodeRunnable.prepareFrameAndCache(DefaultBitmapFramePreparer.java:16)
13
com.facebook.fresco.animation.bitmap.preparation.DefaultBitmapFramePreparer$FrameDecodeRunnable.run(DefaultBitmapFramePreparer.java:6)
14
f.f.b.b.b$b.run(ConstrainedExecutorService.java:2)
15
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
16
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
17
com.facebook.imagepipeline.core.PriorityThreadFactory$1.run(PriorityThreadFactory.java:2)
18
java.lang.Thread.run(Thread.java:764)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the stack trace at AnimatedDrawableBackendImpl.prepareTempBitmapForThisSize and follow its calls through renderImageSupportsScaling, renderFrame, and AnimatedImageCompositor. Investigate the android.graphics.Bitmap.createBitmap failure where width and height are not greater than zero. Done means the reported crash is reproduced or explained and the affected rendering path is covered by an appropriate regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.