facebook / facebook/folly

`IoUringZeroCopyBufferPool` depends on unreleased liburing features

Open
#2,420 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

# Problem Definition

Folly recently added a `IoUringZeroCopyBufferPool` class in 70669ee. However, this class depends on definitions from a liburing version that hasn't been released yet. This is causing issues with packaging Folly.

# Solution

Please add a configure check or build-time flag for a liburing version that supports zcrx.

CC @spikeh since this was part of your changes.

Contributor guide

Open the contributing guide

Research direction

Start with the IoUringZeroCopyBufferPool class added in commit 70669ee and trace the build configuration that exposes its liburing definitions. Check how Folly detects liburing capabilities, then verify that packaging succeeds with released liburing while zcrx support is gated by a configure check or build-time flag.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.