facebook / facebook/folly

Inefficient memory order in SpinLock

Open
#2,389 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

Probably, `std::memory_order_acquire` was intended [here](https://github.com/facebook/folly/blob/b028517fc58f3cec70905f05504e39e270a4457b/folly/synchronization/MicroSpinLock.h#L103), in `folly/folly/synchronization/MicroSpinLock.h`, as `xchg` is only used when obtaining the lock.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.