facebook / facebook/folly

Build error with -Werror=return-type

Open
#2,357 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

Got a build error with -Werror=return-type enabled

folly/folly/settings/Types.cpp: In function ‘std::string_view folly::settings::toString(folly::settings::SetErrorCode)’:
folly/folly/settings/Types.cpp:31:1: error: control reaches end of non-void function [-Werror=return-type]

Contributor guide

Open the contributing guide

Research direction

Open folly/folly/settings/Types.cpp and inspect the toString(folly::settings::SetErrorCode) function named in the compiler error. Reproduce the build with -Werror=return-type, then verify that the warning is resolved and the relevant build succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.