Build failure : it expects c++17
- Dominant language
- C++
- Stars
- 30.5k
- Forks
- 5.9k
- PR merge metrics
- No merged PRs in 30d
Description
Environment:
Compiling folly on OL8 arm64 image running on docker on Apple Silicon M3.
Below logs are thrown while doing a bazel build
# bazel build //third-party/folly:folly --sandbox_debug
If I force it to use c++17 these errors are not seen but different errors from symbolizer are seen. But ideally c++14 should work for folly right ?
Same build works fine on X86
`
ERROR: /root/dpp-workspace/third-party/folly/BUILD:62:11: Compiling third-party/folly/folly/ExceptionWrapper.cpp failed: (Exit 1): process-wrapper failed: error executing CppCompile command
(cd /root/.cache/bazel/_bazel_root/78159c4ab73ed818c6000c3e550185d3/sandbox/processwrapper-sandbox/890/execroot/_main && \
exec env - \
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin \
PWD=/proc/self/cwd \
TMPDIR=/tmp \
/root/.cache/bazel/_bazel_root/install/f9b8dcba838bd6cf80b5db104e050e1b/process-wrapper '--timeout=0' '--kill_delay=15' '--stats=/root/.cache/bazel/_bazel_root/78159c4ab73ed818c6000c3e550185d3/sandbox/processwrapper-sandbox/890/stats.out' /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++14' -MD -MF bazel-out/aarch64-fastbuild/bin/third-party/folly/_objs/folly/ExceptionWrapper.pic.d '-frandom-seed=bazel-out/aarch64-fastbuild/bin/third-party/folly/_objs/folly/ExceptionWrapper.pic.o' -fPIC -DBOOST_NO_CXX98_FUNCTION_BASE -DBOOST_FILESYSTEM_NO_CXX20_ATOMIC_REF -DBOOST_FILESYSTEM_HAS_POSIX_AT_APIS '-DGLOG_DEPRECATED=__attribute__((deprecated))' '-DGLOG_EXPORT=__attribute__((visibility("default")))' '-DGLOG_NO_EXPORT=__attribute__((visibility("default")))' -iquote . -iquote bazel-out/aarch64-fastbuild/bin -iquote external/boost -iquote bazel-out/aarch64-fastbuild/bin/external/boost -iquote external/fmt -iquote bazel-out/aarch64-fastbuild/bin/external/fmt -iquote external/double-conversion~ -iquote bazel-out/aarch64-fastbuild/bin/external/double-conversion~ -iquote external/glog~ -iquote bazel-out/aarch64-fastbuild/bin/external/glog~ -iquote external/gflags~ -iquote bazel-out/aarch64-fastbuild/bin/external/gflags~ -iquote external/zlib~ -iquote bazel-out/aarch64-fastbuild/bin/external/zlib~ -Ibazel-out/aarch64-fastbuild/bin/external/glog~/_virtual_includes/glog -Ibazel-out/aarch64-fastbuild/bin/external/gflags~/_virtual_includes/gflags -isystem third-party/folly -isystem bazel-out/aarch64-fastbuild/bin/third-party/folly -isystem third-party/folly/generated/x86_64-linux-gnu -isystem bazel-out/aarch64-fastbuild/bin/third-party/folly/generated/x86_64-linux-gnu -isystem external/boost/libs/algorithm/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/algorithm/include -isystem external/boost/libs/function/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/function/include -isystem external/boost/libs/bind/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/bind/include -isystem external/boost/libs/get_pointer/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/get_pointer/include -isystem external/boost/libs/is_placeholder/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/is_placeholder/include -isystem external/boost/libs/mem_fn/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/mem_fn/include -isystem external/boost/libs/ref/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/ref/include -isystem external/boost/libs/config/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/config/include -isystem external/boost/libs/core/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/core/include -isystem external/boost/libs/detail/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/detail/include -isystem external/boost/libs/limits/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/limits/include -isystem external/boost/libs/winapi/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/winapi/include -isystem external/boost/libs/utility/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/utility/include -isystem external/boost/libs/container_hash/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/container_hash/include -isystem external/boost/libs/assert/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/assert/include -isystem external/boost/libs/current_function/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/current_function/include -isystem external/boost/libs/describe/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/describe/include -isystem external/boost/libs/mp11/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/mp11/include -isystem external/boost/libs/integer/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/integer/include -isystem external/boost/libs/cstdint/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/cstdint/include -isystem external/boost/libs/static_assert/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/static_assert/include -isystem external/boost/libs/type_traits/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/type_traits/include -isystem external/boost/libs/mpl/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/mpl/include -isystem external/boost/libs/move/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/move/include -isystem external/boost/libs/preprocessor/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/preprocessor/include -isystem external/boost/libs/io/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/io/include -isystem external/boost/libs/swap/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/swap/include -isystem external/boost/libs/throw_exception/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/throw_exception/include -isystem external/boost/libs/type/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/type/include -isystem external/boost/libs/visit_each/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/visit_each/include -isystem external/boost/libs/type_index/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/type_index/include -isystem external/boost/libs/functional/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/functional/include -isystem external/boost/libs/iterator/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/iterator/include -isystem external/boost/libs/range/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/range/include -isystem external/boost/libs/array/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/array/include -isystem external/boost/libs/concept_check/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/concept_check/include -isystem external/boost/libs/concept/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/concept/include -isystem external/boost/libs/concept_archetype/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/concept_archetype/include -isystem external/boost/libs/noncopyable/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/noncopyable/include -isystem external/boost/libs/optional/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/optional/include -isystem external/boost/libs/none/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/none/include -isystem external/boost/libs/regex/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/regex/include -isystem external/boost/libs/exception/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/exception/include -isystem external/boost/libs/smart_ptr/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/smart_ptr/include -isystem external/boost/libs/align/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/align/include -isystem external/boost/libs/predef/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/predef/include -isystem external/boost/libs/scoped_array/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/scoped_array/include -isystem external/boost/libs/checked_delete/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/checked_delete/include -isystem external/boost/libs/scoped_ptr/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/scoped_ptr/include -isystem external/boost/libs/shared_array/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/shared_array/include -isystem external/boost/libs/shared_ptr/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/shared_ptr/include -isystem external/boost/libs/tuple/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/tuple/include -isystem external/boost/libs/container/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/container/include -isystem external/boost/libs/intrusive/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/intrusive/include -isystem external/boost/libs/context/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/context/include -isystem external/boost/libs/pool/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/pool/include -isystem external/boost/libs/conversion/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/conversion/include -isystem external/boost/libs/fusion/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/fusion/include -isystem external/boost/libs/call_traits/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/call_traits/include -isystem external/boost/libs/function_types/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/function_types/include -isystem external/boost/libs/typeof/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/typeof/include -isystem external/boost/libs/crc/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/crc/include -isystem external/boost/libs/filesystem/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/filesystem/include -isystem external/boost/libs/atomic/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/atomic/include -isystem external/boost/libs/scope/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/scope/include -isystem external/boost/libs/system/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/system/include -isystem external/boost/libs/cerrno/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/cerrno/include -isystem external/boost/libs/variant2/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/variant2/include -isystem external/boost/libs/multi_index/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/multi_index/include -isystem external/boost/libs/foreach/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/foreach/include -isystem external/boost/libs/serialization/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/serialization/include -isystem external/boost/libs/archive/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/archive/include -isystem external/boost/libs/spirit/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/spirit/include -isystem external/boost/libs/endian/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/endian/include -isystem external/boost/libs/iostreams/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/iostreams/include -isystem external/boost/libs/numeric/conversion/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/numeric/conversion/include -isystem external/boost/libs/random/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/random/include -isystem external/boost/libs/lexical_cast/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/lexical_cast/include -isystem external/boost/libs/chrono/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/chrono/include -isystem external/boost/libs/operators/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/operators/include -isystem external/boost/libs/ratio/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/ratio/include -isystem external/boost/libs/math/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/math/include -isystem external/boost/libs/math/include_private -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/math/include_private -isystem external/boost/libs/lambda/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/lambda/include -isystem external/boost/libs/timer/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/timer/include -isystem external/boost/libs/phoenix/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/phoenix/include -isystem external/boost/libs/proto/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/proto/include -isystem external/boost/libs/tti/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/tti/include -isystem external/boost/libs/variant/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/variant/include -isystem external/boost/libs/program_options/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/program_options/include -isystem external/boost/libs/any/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/any/include -isystem external/boost/libs/tokenizer/include -isystem bazel-out/aarch64-fastbuild/bin/external/boost/libs/tokenizer/include -isystem external/fmt/include -isystem bazel-out/aarch64-fastbuild/bin/external/fmt/include -isystem external/double-conversion~ -isystem bazel-out/aarch64-fastbuild/bin/external/double-conversion~ -isystem external/zlib~/zlib/include -isystem bazel-out/aarch64-fastbuild/bin/external/zlib~/zlib/include -isystem bazel-out/aarch64-fastbuild/bin/external/libevent/event/include -DFIU_ENABLE -pthread -Wno-pedantic -Wno-old-style-cast -Wno-switch-enum -Wno-format-nonliteral -Wno-conversion -Wno-cast-align -Wno-float-equal -Wno-sign-conversion -Wno-shadow -Wno-unused-variable -Wno-missing-field-initializers -Wno-redundant-decls -Wno-missing-declarations '-Wno-suggest-attribute=format' -Wno-switch-default -Wno-zero-as-null-pointer-constant -Wno-overflow -Wno-cast-qual -Wno-sign-promo -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c third-party/folly/folly/ExceptionWrapper.cpp -o bazel-out/aarch64-fastbuild/bin/third-party/folly/_objs/folly/ExceptionWrapper.pic.o)
In file included from third-party/folly/folly/CppAttributes.h:23,
from third-party/folly/folly/ExceptionWrapper.h:30,
from third-party/folly/folly/ExceptionWrapper.cpp:17:
third-party/folly/folly/Portability.h:35:31: error: static assertion failed: __cplusplus >= 201703L
35 | static_assert(FOLLY_CPLUSPLUS >= 201703L, "__cplusplus >= 201703L");
| ^
In file included from third-party/folly/folly/FBString.h:39,
from third-party/folly/folly/Demangle.h:19,
from third-party/folly/folly/ExceptionWrapper.h:31,
from third-party/folly/folly/ExceptionWrapper.cpp:17:
third-party/folly/folly/Traits.h:109:47: error: expected template-name before '<' token
109 | struct is_unbounded_array : std::bool_constant> {};
| ^
third-party/folly/folly/Traits.h:109:47: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:122:45: error: expected template-name before '<' token
122 | struct is_bounded_array : std::bool_constant> {};
| ^
third-party/folly/folly/Traits.h:122:45: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:141:25: error: expected template-name before '<' token
141 | : std::bool_constant> {};
| ^
third-party/folly/folly/Traits.h:141:25: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:149:25: error: expected template-name before '<' token
149 | : std::bool_constant> {};
| ^
third-party/folly/folly/Traits.h:149:25: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:202:25: error: expected template-name before '<' token
202 | : std::bool_constant> {};
| ^
third-party/folly/folly/Traits.h:202:25: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:462:25: error: expected template-name before '<' token
462 | : std::bool_constant> {};
| ^
third-party/folly/folly/Traits.h:462:25: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:597:16: error: 'bool_constant' is not a member of 'std'; did you mean 'fmt::v10::bool_constant'?
597 | std::bool_constant< //
| ^~~~~~~~~~~~~
In file included from external/fmt/include/fmt/format.h:49,
from third-party/folly/folly/FBString.h:34,
from third-party/folly/folly/Demangle.h:19,
from third-party/folly/folly/ExceptionWrapper.h:31,
from third-party/folly/folly/ExceptionWrapper.cpp:17:
external/fmt/include/fmt/core.h:274:25: note: 'fmt::v10::bool_constant' declared here
274 | template using bool_constant = std::integral_constant;
| ^~~~~~~~~~~~~
In file included from third-party/folly/folly/FBString.h:39,
from third-party/folly/folly/Demangle.h:19,
from third-party/folly/folly/ExceptionWrapper.h:31,
from third-party/folly/folly/ExceptionWrapper.cpp:17:
third-party/folly/folly/Traits.h:597:16: error: 'bool_constant' is not a member of 'std'; did you mean 'fmt::v10::bool_constant'?
597 | std::bool_constant< //
| ^~~~~~~~~~~~~
In file included from external/fmt/include/fmt/format.h:49,
from third-party/folly/folly/FBString.h:34,
from third-party/folly/folly/Demangle.h:19,
from third-party/folly/folly/ExceptionWrapper.h:31,
from third-party/folly/folly/ExceptionWrapper.cpp:17:
external/fmt/include/fmt/core.h:274:25: note: 'fmt::v10::bool_constant' declared here
274 | template using bool_constant = std::integral_constant;
| ^~~~~~~~~~~~~
In file included from third-party/folly/folly/FBString.h:39,
from third-party/folly/folly/Demangle.h:19,
from third-party/folly/folly/ExceptionWrapper.h:31,
from third-party/folly/folly/ExceptionWrapper.cpp:17:
third-party/folly/folly/Traits.h:601:15: error: type/value mismatch at argument 3 in template parameter list for 'template, class, class> struct std::conditional'
601 | true>>::type {};
| ^~~~
third-party/folly/folly/Traits.h:601:15: note: expected a type, got '(((( < (! std::is_class::value)) && (! std::is_union::value)) && (! std::is_member_object_pointer::value)) && true)'
third-party/folly/folly/Traits.h:601:19: error: expected '{' before '>' token
601 | true>>::type {};
| ^~
third-party/folly/folly/Traits.h:645:37: error: expected template-name before '<' token
645 | struct Negation : std::bool_constant {};
| ^
third-party/folly/folly/Traits.h:645:37: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:678:43: error: expected template-name before '<' token
678 | struct is_transparent : std::bool_constant> {};
| ^
third-party/folly/folly/Traits.h:678:43: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:704:41: error: expected template-name before '<' token
704 | struct is_allocator : std::bool_constant> {};
| ^
third-party/folly/folly/Traits.h:704:41: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:784:25: error: expected template-name before '<' token
784 | : std::bool_constant::value && IsRelocatable::value> {};
| ^
third-party/folly/folly/Traits.h:784:25: error: expected '{' before '<' token
third-party/folly/folly/Traits.h:1086:10: error: 'is_default_constructible_v' is not a member of 'std'; did you mean 'is_default_constructible'?
1086 | std::is_default_constructible_v &&
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| is_default_constructible
third-party/folly/folly/Traits.h:1086:10: error: 'is_default_constructible_v' is not a member of 'std'; did you mean 'is_default_constructible'?
1086 | std::is_default_constructible_v &&
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| is_default_constructible
third-party/folly/folly/Traits.h:1086:43: error: template argument 2 is invalid
1086 | std::is_default_constructible_v &&
| ^
third-party/folly/folly/Traits.h:1097:44: error: 'is_hasher_usable' was not declared in this scope; did you mean 'is_hasher_usable_v'?
1097 | inline constexpr bool is_hasher_usable_v = is_hasher_usable::value;
| ^~~~~~~~~~~~~~~~
| is_hasher_usable_v
third-party/folly/folly/Traits.h:1097:62: error: expected primary-expression before ',' token
1097 | inline constexpr bool is_hasher_usable_v = is_hasher_usable::value;
| ^
In file included from third-party/folly/folly/hash/Hash.h:43,
from third-party/folly/folly/FBString.h:40,
from third-party/folly/folly/Demangle.h:19,
from third-party/folly/folly/ExceptionWrapper.h:31,
from third-party/folly/folly/ExceptionWrapper.cpp:17:
third-party/folly/folly/Utility.h:376:11: error: 'auto' parameter not permitted in this context
376 | template
| ^~~~
third-party/folly/folly/Utility.h:379:27: error: 'value_type' does not name a type
379 | static inline constexpr value_type value = Value;
| ^~~~~~~~~~
third-party/folly/folly/Utility.h:381:13: error: 'value_type' does not name a type
381 | constexpr value_type operator()(A&&...) const noexcept {
| ^~~~~~~~~~
third-party/folly/folly/Utility.h:385:11: error: 'auto' parameter not permitted in this context
385 | template
| ^~~~
third-party/folly/folly/Utility.h:486:27: error: expected template-name before '<' token
486 | : std::bool_constant> {};
| ^
third-party/folly/folly/Utility.h:486:27: error: expected '{' before '<' token
In file included from third-party/folly/folly/functional/Invoke.h:33,
from third-party/folly/folly/functional/ApplyTuple.h:25,
from third-party/folly/folly/hash/Hash.h:44,
from third-party/folly/folly/FBString.h:40,
from third-party/folly/folly/Demangle.h:19,
from third-party/folly/folly/ExceptionWrapper.h:31,
from third-party/folly/folly/ExceptionWrapper.cpp:17:
third-party/folly/folly/lang/CustomizationPoint.h:55:11: error: 'auto' parameter not permitted in this context
`
Contributor guide
Assessment
This issue has not been assessed yet.