facebook / facebook/folly

Support glog 0.7.0

Open
#2,171 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

👋 trying to build fizz with glog 0.7.0, but ran into some regression test failure as below:

```
==> /usr/bin/clang++ -std=c++17 test.cpp -o test -I/opt/homebrew/Cellar/fizz/2024.04.01.00_1/include -I/opt/homebrew/opt/openssl@3/include -L/opt/homebrew/Cellar/fizz/2024.04.01.00_1/lib -lfizz -L/opt/homebrew/opt/folly/lib -lfolly -L/opt/homebrew/opt/gflags/lib -lgflags -L/opt/homebrew/opt/glog/lib -lglog -L/opt/homebrew/opt/libevent/lib -levent -L/opt/homebrew/opt/libsodium/lib -lsodium -L/opt/homebrew/opt/openssl@3/lib -lcrypto -lssl
In file included from test.cpp:1:
In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/client/AsyncFizzClient.h:11:
In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/client/ClientExtensions.h:11:
In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/record/Types.h:12:
In file included from /opt/homebrew/include/folly/io/Cursor.h:31:
In file included from /opt/homebrew/include/folly/io/IOBuf.h:33:
/opt/homebrew/include/glog/logging.h:60:4: error: was not included correctly. See the documention for how to consume the library.
# error was not included correctly. See the documention for how to consume the library.
^
```

same failure seen for wangle as well.

relates to https://github.com/Homebrew/homebrew-core/pull/163094

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.