facebook / facebook/folly

v2024.02.19 branch FTBFS / glog was not included correctly

Open
#2,149 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

Version affected: v2024.02.19.00
Version affected: 89a350d4cfa34522e0ce2967970622240465eb2f

```
[ 8s] [ 0%] Building CXX object CMakeFiles/folly_base.dir/folly/CancellationToken.cpp.o
[ 8s] /usr/bin/c++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DFMT_SHARED -DFOLLY_XLOG_STRIP_PREFIXES=\"/home/abuild/rpmbuild/BUILD/folly-2024.02.19.00:/home/abuild/rpmbuild/BUILD/folly-2024.02.19.00/build\" -DGFLAGS_IS_A_DLL=0 -D_GNU_SOURCE -D_REENTRANT -I/home/abuild/rpmbuild/BUILD/folly-2024.02.19.00 -I/home/abuild/rpmbuild/BUILD/folly-2024.02.19.00/build -I/usr/include/libdwarf -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -ffat-lto-objects -fPIC -O2 -g -DNDEBUG -std=gnu++17 -fPIC -fcoroutines -g -finput-charset=UTF-8 -fsigned-char -Wall -Wno-deprecated -Wno-deprecated-declarations -Wno-sign-compare -Wno-unused -Wuninitialized -Wunused-label -Wunused-result -Wshadow-compatible-local -Wno-noexcept-type -faligned-new -fopenmp -MD -MT CMakeFiles/folly_base.dir/folly/CancellationToken.cpp.o -MF CMakeFiles/folly_base.dir/folly/CancellationToken.cpp.o.d -o CMakeFiles/folly_base.dir/folly/CancellationToken.cpp.o -c /home/abuild/rpmbuild/BUILD/folly-2024.02.19.00/folly/CancellationToken.cpp
[ 8s] In file included from /home/abuild/rpmbuild/BUILD/folly-2024.02.19.00/folly/CancellationToken-inl.h:23,
[ 8s] from /home/abuild/rpmbuild/BUILD/folly-2024.02.19.00/folly/CancellationToken.h:365,
[ 8s] from /home/abuild/rpmbuild/BUILD/folly-2024.02.19.00/folly/CancellationToken.cpp:17:
[ 8s] /usr/include/glog/logging.h:60:4: error: #error was not included correctly. See the documention for how to consume the library.
[ 8s] 60 | # error was not included correctly. See the documention for how to consume the library.
```

This is due to a change in glog: https://github.com/google/glog/commit/39df0545e7688309f49e17acd48aa64485ab0184

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.