facebook / facebook/folly

How to safely disable CacheLocality technique if cpu files are not as expected(ppc64le)?

Open
#1,930 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

Is it safe to **disable `CacheLocality` technique** by removing the "unable to load cache sharing info" exception at folly/concurrency/CacheLocality.cpp:L164 ?

On our ppc64le machine, the cpu files maybe not as expected on other architectures like x86_64:

image

The impl expects there is file named "shared_cpu_list" in "/sys/devices/system/cpu/cpu0/cache/index0/"
image

If no file named "shared_cpu_list" is found, the impl will throw exception:
image

So is it safe to **disable `CacheLocality` technique** by removing the "unable to load cache sharing info" exception at folly/concurrency/CacheLocality.cpp:L164 ?

Contributor guide

Open the contributing guide

Research direction

Start by reading folly/concurrency/CacheLocality.cpp around line 164 and compare the expected cache files with the ppc64le layout shown in the issue. Determine whether the missing shared_cpu_list should produce a safe fallback or an error, and verify the chosen behavior on the affected platform.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.