facebook / facebook/folly

F14TableStats computeStats() line 2301

Open
#1,738 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

should it be:
uint8_t tag = static_cast(ti == 0 ? 1 : tag);
but the code is:
uint8_t tag = static_cast(ti == 0 ? 1 : 0);
?

Contributor guide

Open the contributing guide

Research direction

Start at F14TableStats::computeStats() around line 2301 and read the surrounding tag calculation to determine whether the proposed expression matches the intended behavior. Validate the conclusion with the relevant F14 tests, and consider the issue done when the behavior is resolved and covered by a passing test.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.