conv.cpp causes int truncation errors in MSVC
- Dominant language
- C++
- Stars
- 30.5k
- Forks
- 5.9k
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/facebook/folly/blob/8f60f6338641eec89d7255625de81cc20af6a2a1/folly/Conv.cpp#L589
```
E:\rnw\node_modules\.folly\folly-2020.09.14.00\folly\Conv.cpp(589,18): error C2220: the following warning is treated as an error [E:\rnw\vnext\Folly\Folly.vcxproj]
E:\rnw\node_modules\.folly\folly-2020.09.14.00\folly\Conv.cpp(647): message : see reference to function template instantiation 'folly::Expected folly::detail::digits_to(const char *,const char *) noexce
pt' being compiled [E:\rnw\vnext\Folly\Folly.vcxproj]
E:\rnw\node_modules\.folly\folly-2020.09.14.00\folly\Conv.cpp(589,18): warning C4310: cast truncates constant value [E:\rnw\vnext\Folly\Folly.vcxproj]
```
Contributor guide
Assessment
This issue has not been assessed yet.