Benchmark.cpp error: expected ‘)’ before ‘PRId64’
Open
- Dominant language
- C++
- Stars
- 30.5k
- Forks
- 5.9k
- PR merge metrics
- No merged PRs in 30d
Description
The following compile error is seen when building folly (v2020.08.24.00) using GCC 7.3.0 on CentOS 7:
```
folly/folly/Benchmark.cpp:340:30: error: expected ‘)’ before ‘PRId64’
printf(" %-*" PRId64, int(name.length()), ptr->value);
```
This seems to be a variant of https://github.com/facebook/folly/pull/467 - `PRId64` is not available as `__STDC_FORMAT_MACROS` is not defined before is included in Benchmark.cpp.
Contributor guide
Assessment
This issue has not been assessed yet.