facebook / facebook/folly

Using the official libevent export for findfind_package()

Open
#1,423 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

The current `find_package` call looks like:
https://github.com/facebook/folly/blob/8cde5e001a9de1feea442b32444d15985e8167c4/CMake/folly-deps.cmake#L67

However libevent install looks like:
https://github.com/libevent/libevent/blob/e3e7bb212ea17aa8a9d5a30163487342e6ebb350/CMakeLists.txt#L1561-L1563

It would be nice if this was changed to:

```diff
-find_package(LibEvent MODULE REQUIRED)
+find_package(Libevent MODULE REQUIRED)
```

for better integration with other tools and projects

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.