facebook / facebook/folly

FBthrift not building with Folly

Open
#1,140 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
30.5k
Forks
5.9k
PR merge metrics
No merged PRs in 30d

Description

Folly is getting build with Python extension and getting installed as shown

below/usr/local/lib/python3.6/dist-packages/folly-0.0.1-py3.6-linux-x86_64.egg/folly/
├── AsyncioExecutor.h
├── __init__.pxd
├── __pycache__
│   └── executor.cpython-36.pyc
├── executor.cpython-36m-x86_64-linux-gnu.so
├── executor.pxd
├── executor.py
├── executor_api.h
├── futures.pxd
└── range.pxd

While building FBThrift it looks for a file called Folly.pxd which is non exsistent. Please see the log below

******Error compiling Cython file:**
------------------------------------------------------------**
...

from libcpp.string cimport string
from libc.stdint cimport uint64_t
from libcpp.memory cimport unique_ptr
from libc.string cimport const_uchar
from folly cimport cFollyExecutor
^
------------------------------------------------------------**

/usr/local/src/fbthrift/_build/thrift/lib/py3/cybld/folly/iobuf.pxd:7:0: 'folly.pxd' not found
thrift/lib/py3/test/CMakeFiles/optional-services-py3.dir/build.make:61: recipe for target 'thrift/lib/py3/test/gen-py3/optional/services.cpp' failed
make[2]: *** [thrift/lib/py3/test/gen-py3/optional/services.cpp] Error 1
make[2]: *** Deleting file 'thrift/lib/py3/test/gen-py3/optional/services.cpp'
CMakeFiles/Makefile2:2009: recipe for target 'thrift/lib/py3/test/CMakeFiles/optional-services-py3.dir/all' failed
make[1]: *** [thrift/lib/py3/test/CMakeFiles/optional-services-py3.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 82%] Built target stack_args-cpp2
[ 82%] Built target binary-py3-target
[ 82%] Built target testing-py3-target
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.