facebook / facebook/flow

Still checking non-dependencies in node_modules

Open
#5,164 7 comments 14 reactions 0 assignees View on GitHub
Windows support
Dominant language
Rust
Stars
22.3k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

The release notes of 0.57.0 mention this new feature:

> Flow will now only check the files in `node_modules/` which are direct or transitive dependencies of the non-`node_modules` code.

However, even with 0.57.3 (on Windows 7, if that matters), I'm still experiencing the same issue as in these reports:

#5023
https://github.com/dcodeIO/bcrypt.js/issues/66

The `bower.json` file is neither a direct nor a transitive dependency of my non-node_modules code, but it still gets checked, which results in a failure.

If I rename it so it doesn't have a `.json` extension, Flow stops checking it.

I've also noticed from the server output that Flow is monitoring `.css` and `.png` files in node_modules for changes, which seems like unnecessary extra work.

Is this a bug or intentional?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.