facebook / facebook/flow

project containing bcryptjs is failing to run flow

Open
#5,023 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
22.3k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

```
capaj@capaj-i7-4771:~/git_projects/looop/project-alpha/back-end$ nb flow --version
Warning: `flow --version` is deprecated in favor of `flow version`
Flow, a static type checker for JavaScript, version 0.55.0
capaj@capaj-i7-4771:~/git_projects/looop/project-alpha/back-end$ nb flow
Error: node_modules/bcryptjs/src/bower.json:4
4: "version": /*?== VERSION */,
^ Unexpected token ,

Found 1 error
capaj@capaj-i7-4771:~/git_projects/looop/project-alpha/back-end$
```

the file which is failing is just a template, not an actual bower.json file:
https://github.com/dcodeIO/bcrypt.js/blob/master/src/bower.json

Also why is flow parsing bower.json? Bower is deprecated anyway. I know it might be controversial, but I say remove bower support. 99% of people use NPM anyway.

I tried putting the file into ignore but it doesn't help.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.