facebook / facebook/flow

event (lowercased) is not being type and declaration checked

Open
#3,481 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
22.3k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

Hey guys, and small bug here:

If you use a variable, named `event`, even if it was never declared in your scope, flow does not throw an error about it.

example:
```
/@flow
// No declaration of any kind
const work = `${event.toString()}`; // Should fail
const fail = `${evnt.toString()}`; // Fail as expected
```
https://flowtype.org/try/#0PQKgBAAgZgNg9gdzCYAoVBjOA7AzgFzATgCcBrMAXjAAMASAbwFMA3J7fAOnzgGV8SAS2wBzABQBKAL40A3JhwEwUAIaCYVWo1YdufAcPHS5QA

I believe it is related to this:
https://github.com/facebook/flow/blob/v0.40.0/lib/dom.js#L3090

What do you think? Thank you team in advance!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.