String substr/substring first argument should be optional
Open
Library definitions
- Dominant language
- Rust
- Stars
- 22.3k
- Forks
- 1.9k
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/facebook/flow/blob/master/lib/core.js#L262-L263
```typescript
substr(from: number, length?: number): string;
substring(start: number, end?: number): string;
```
As I understand it, [ES5 B.2.3](http://www.ecma-international.org/ecma-262/5.1/#sec-B.2.3) and [15.5.4.15](http://www.ecma-international.org/ecma-262/5.1/#sec-15.5.4.15) do not require the first argument to be defined. Step 2 of substr (step 4 of substring) converts the argument to integer, and an undefined value will converted to zero.
Contributor guide
Assessment
This issue has not been assessed yet.