facebook / facebook/flow

The `throw` operator should be more strict

Open
#2,172 3 comments 0 reactions 0 assignees View on GitHub
linter
Dominant language
Rust
Stars
22.3k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

I tried searching, but I didn't find any existing issues about this.

Currently, using version 0.30.0 of flow-bin, the following code shows no errors:

```
function foo() {
throw null;
}

function bar() {
throw 5;
}

function qux() {
throw [];
}
```

It seems that the `throw` operator will accept any type.

I think it should only accept `Error`. If that is too restrictive, it could be relaxed to `Error | string`.

This actually bit me when I was writing a function which accepts an optional argument: if the argument is not provided, then it will `throw` `undefined`, which is not what I wanted.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.