facebook / facebook/facebook-ios-sdk

`UIApplication.shared.open(url:)` handled by `FBSDKInternalURLOpener` starting with `15.0.0`

Open
#2,303 1 comment 2 reactions 0 assignees View on GitHub
bug needs-triage
Dominant language
Swift
Stars
8.1k
Forks
3.7k
PR merge metrics
No merged PRs in 30d

Description

### Checklist before submitting a bug report

- [X] I've updated to the latest released version of the SDK
- [X] I've searched for existing [GitHub issues](https://github.com/facebook/facebook-ios-sdk/issues)
- [X] I've looked for existing answers on [Stack Overflow](https://facebook.stackoverflow.com), the [Facebook Developer Community Forum](https://developers.facebook.com/community/) and the [Facebook Developers Group](https://www.facebook.com/groups/fbdevelopers)
- [X] I've read the [Code of Conduct](https://github.com/facebook/facebook-ios-sdk/blob/main/CODE_OF_CONDUCT.md)
- [X] This issue is not security related and can safely be disclosed publicly on GitHub

### Xcode version

14.3.1

### Facebook iOS SDK version

15.0.0

### Dependency Manager

SPM

### SDK Framework

Core

### Goals

Currently we are using `12.1.0` version of the SDK we want to be up to date with the latest SDK version.

Breaking changes starting from the `13.0.0` were addressed as part of the migration and up to `14.1.0` version Facebook SDK doesn't seem to affect behaviour of the application in any significant way.

When updated to `15.0.0` and later one significant issue appears.

### Expected results

`UIApplication.shared.open(url:)` invoked within the application
`UIApplication` implementation handles the invocation

### Actual results

`UIApplication.shared.open(url:)` invoked within the application
`FBSDKInternalURLOpener` handles the invocation

### Steps to reproduce

I believe there is an issue with this commit that exposed `FBSDKInternalURLOpener`: https://github.com/facebook/facebook-ios-sdk/commit/f3127fb22f0b3dbbcd9213dfec8929fe930fc9c7

### Code samples & details

```swift
import FacebookCore

UIApplication.shared.open(url:) -> Jump to Definition in Xcode -> FBSDKInternalURLOpener is opened
UIApplication.shared.open(url:, options: [:]) -> Jump to Definition in Xcode -> UIApplication is opened
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.