facebook / facebook/facebook-ios-sdk

FBSDKCoreKit.framework: Unsealed contents present in the root directory of an embedded framework

Open
#2,130 5 comments 3 reactions 0 assignees View on GitHub
bug needs-triage
Dominant language
Swift
Stars
8.1k
Forks
3.7k
PR merge metrics
No merged PRs in 30d

Description

### Checklist before submitting a bug report

- [X] I've updated to the latest released version of the SDK
- [X] I've searched for existing [GitHub issues](https://github.com/facebook/facebook-ios-sdk/issues)
- [X] I've looked for existing answers on [Stack Overflow](https://facebook.stackoverflow.com), the [Facebook Developer Community Forum](https://developers.facebook.com/community/) and the [Facebook Developers Group](https://www.facebook.com/groups/fbdevelopers)
- [X] I've read the [Code of Conduct](https://github.com/facebook/facebook-ios-sdk/blob/main/CODE_OF_CONDUCT.md)
- [X] This issue is not security related and can safely be disclosed publicly on GitHub

### Xcode version

14.0

### Facebook iOS SDK version

14.1.0

### Dependency Manager

CocoaPods

### SDK Framework

Core

### Goals

The directory structure of `FBSDKCoreKit.framework` is invalid for an embedded framework, because `FacebookSDKStrings.bundle` is in the wrong place. This prevents macCatalyst builds when the app includes `FBSDKCoreKit`, because code signing will fail.

Simply moving `FBSDKCoreKit/XCFrameworks/FBSDKCoreKit.xcframework/ios-arm64_x86_64-maccatalyst/FBSDKCoreKit.framework/FacebookSDKStrings.bundle` to `FBSDKCoreKit/XCFrameworks/FBSDKCoreKit.xcframework/ios-arm64_x86_64-maccatalyst/FBSDKCoreKit.framework/Versions/A/Resources/FacebookSDKStrings.bundle` fixes this issue.

### Expected results

You should be able to codesign the `FBSDKCoreKit` framework for macCatalyst without issue.

### Actual results

```
/usr/bin/codesign --force --sign --preserve-metadata=identifier,entitlements '/Users/bdaz/Library/Developer/Xcode/DerivedData/Thoughtful-cbuhkdrltepatyaqufbenzszbwvr/Build/Products/Debug-maccatalyst/Thoughtful.app/Contents/Frameworks/FBSDKCoreKit.framework'

/Users/bdaz/Library/Developer/Xcode/DerivedData/Thoughtful-cbuhkdrltepatyaqufbenzszbwvr/Build/Products/Debug-maccatalyst/Thoughtful.app/Contents/Frameworks/FBSDKCoreKit.framework: unsealed contents present in the root directory of an embedded framework
```

### Steps to reproduce

1. Add `FBSDKCoreKit` as a dependency. In my case, I'm using Cocoapods.
2. Try to build your app for macCatalyst.

### Code samples & details

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.