facebook / facebook/duckling

Up Text and Hashable constraints

Open
#730 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
4.3k
Forks
740
PR merge metrics
No merged PRs in 30d

Description

In #724 I bump aeson and make it work across versions.

It would be good if duckling can update the constraints on Text and Hashable so it works on a modern version of GHC.

for hashable, one merely needs to add the following to Duckling.Types:
```hs
-- Eq
instance Eq (Dimension a) where
(==) a b = hash a == hash b
```

For Text there are more detailed changes needed, as Text switches from UTF-16 to UTF-8, and Duckling uses internals functions to manipulate Texts.

Suggested new bounds are `hashable >= 1.2.4.0 && < 1.5` and `text >= 2 && < 2.2`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.