facebook / facebook/duckling

Written out larger decimal numbers are not detected correctly

Open
#686 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
4.3k
Forks
740
PR merge metrics
No merged PRs in 30d

Description

E.g. "5.33 thousand" is correctly detected as "5330". However, if written out "five point three three thousand" is detected as "5.3" and "3000".
This is a problem in at least German and English.
Unfortunately, I do not know if this is actually solvable (regex greediness?).

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the English and German examples from the issue and inspect Duckling's number-detection rules and their tests. Done means that both written-out decimal examples are interpreted as one value matching the numeric form, without breaking existing number recognition.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.