facebook / facebook/duckling

[Time] Format `YYYY-Month-DD` does not get properly extracted.

Open
#336 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
4.3k
Forks
740
PR merge metrics
No merged PRs in 30d

Description

Hi, thanks for this great library! I've noticed an issue related to time parsing. Dates of the format `YYYY-Month-DD`, e.g. `2019-Feb-21` do not get properly extracted. Two issues:
- The year is extracted as a number, and not as a part of the date. So `2019-Feb-21` gives two entities: `2019` (number) and `Feb-21` (date).
- Even when just considering the date that gets extracted, that date is wrong. For instance, `2017-Dec-18` gets extracted to `01/12/1982`.

Contributor guide

Open the contributing guide

Research direction

No file or test entry point is named in the issue. Reproduce the examples `2019-Feb-21` and `2017-Dec-18`, then locate the time-parsing rules and their existing tests; done means the full input is extracted as one date and resolves to the correct year, month, and day.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.