facebook / facebook/duckling

inconsistent parsing for time with numbers

Open
#13 3 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Haskell
Stars
4.3k
Forks
740
PR merge metrics
No merged PRs in 30d

Description

this one is just wrong
```bash
$ curl -s -XPOST http://0.0.0.0:8000/parse --data "text=the second sunday of October last year" | jq .
[
{
"dim": "time",
"body": "the second sunday of October last year",
"value": "{\"values\":[],\"value\":\"2016-10-02T00:00:00.000-07:00\",\"grain\":\"day\",\"type\":\"value\"}",
"start": 0,
"end": 38
}
]
```

this one gets both parts right, but why did just changing the one word change so much of the parsing?
```bash
$ curl -s -XPOST http://0.0.0.0:8000/parse --data "text=the second thursday of October last year" | jq .
[
{
"dim": "time",
"body": "the second thursday of October",
"value": "{\"values\":[{\"value\":\"2017-10-12T00:00:00.000-07:00\",\"grain\":\"day\",\"type\":\"value\"}],\"value\":\"2017-10-12T00:00:00.000-07:00\",\"grain\":\"day\",\"type\":\"value\"}",
"start": 0,
"end": 30
},
{
"dim": "time",
"body": "thursday of October last year",
"value": "{\"values\":[],\"value\":\"2016-10-06T00:00:00.000-07:00\",\"grain\":\"day\",\"type\":\"value\"}",
"start": 11,
"end": 40
}
]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.