facebook / facebook/docusaurus

collapsing a sidebar erroneously shows a collapse animation for open sub-items

Open
#8,512 2 comments 0 reactions 0 assignees View on GitHub
bug domain: theme
Dominant language
TypeScript
Stars
66.2k
Forks
10k
Avg merge
1d 3h
Merged PRs (30d)
52

Description

### Have you read the Contributing Guidelines on issues?

- [X] I have read the [Contributing Guidelines on issues](https://github.com/facebook/docusaurus/blob/main/CONTRIBUTING.md#reporting-new-issues).

### Prerequisites

- [X] I'm using the latest version of Docusaurus.
- [X] I have tried the `npm run clear` or `yarn clear` command.
- [X] I have tried `rm -rf node_modules yarn.lock package-lock.json` and re-installing packages.
- [ ] I have tried creating a repro with https://new.docusaurus.io.
- [X] I have read the console error message carefully (if applicable).

### Description

When a sidebar has nested sections, collapsing the parent also shows the animation for the children icons.

https://user-images.githubusercontent.com/6070939/210901282-c0ba9a5d-c5f0-411c-9392-aaacbfb3776c.mov

Notice how the icon to the right of "iOS and Android Apps" spins even though the parent "Demos" block is collapsing.

It is surprising because the nested groups are not collapsed when the parent group is uncollapsed.

### Reproducible demo

https://git.sheetjs.com/sheetjs/docs.sheetjs.com

### Steps to reproduce

Visit https://docs.sheetjs.com/docs/demos/mobile/ on a computer and click the chevron next to "Demos". Observe that two icons rotate

### Expected behavior

Only the Demos chevron rotates (since the inner block does not collapse when you expand the Demos group again)

### Actual behavior

Both chevrons rotate

### Your environment

- Public source code: https://git.sheetjs.com/sheetjs/docs.sheetjs.com
- Public site URL: https://docs.sheetjs.com/docs/demos/mobile/
- Docusaurus version used: 2.2.0
- Environment name and version (e.g. Chrome 89, Node.js 16.4): Chrome 108
- Operating system and version (e.g. Ubuntu 20.04.2 LTS): macOS 12.6

### Self-service

- [ ] I'd be willing to fix this bug myself.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.