facebook / facebook/buck2

project.ignore doesn't work with inotify

Open
#465 14 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4.4k
Forks
394
PR merge metrics
No merged PRs in 30d

Description

Does the buck2 daemon using inotify honor the project.ignore setting? My .buckconfig file contains:

```
[project]
ignore = ext
```

The ext directory contains 3rd party files (headers and libraries) that are used as dependencies and is very large (100k+ files). We treat these as system files and don't need to track changes to those files. Running buck2 runs into the system `fs.inotify.max_user_watches` limit. Output:

```
>buck2 targets //...
Build ID: d38e98b1-262a-45e8-ac69-1c1dcc4bb097
Error initializing DaemonStateData

Caused by:
0: Error creating a FileWatcher for project root `<>/dev`
1: Creating notify file watcher
2: OS file watch limit reached. about ["<>/dev/ext/boost_1_71_0/src/boost_1_71_0/boost/phoenix/core/detail"]
Build ID: d38e98b1-262a-45e8-ac69-1c1dcc4bb097
Jobs completed: 0. Time elapsed: 0.0s.
```
Note that the error message shows that the problem is with the "ext" directory which should have been ignored. Removing the directory makes the failure go away.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.