facebook / facebook/buck2

Deps for `sh_binary` are unsupported

Open
#287 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4.4k
Forks
394
PR merge metrics
No merged PRs in 30d

Description

As of the time of posting, the [docs](https://buck2.build/docs/api/rules/#sh_binary) indicate that `sh_binary` has a `deps` attr. However, [`deps` are currently unsupported](https://github.com/facebook/buck2/blob/3735c5b4c7ec25216eb48b0ceb5bcdc2a2351bc0/prelude/sh_binary.bzl#L105-L111) for `sh_binary`. I suspect the docs are out of date or the `deps` inclusion was a mistake, but it would be awesome of `sh_binary` could support deps.

One workflow example: you have a `docker compose up` script a and `docker compose down` script with two corresponding `sh_binary` targets. However, you want the `up` target to depend on the `down` target.

Perhaps `deps` might not be the right keyword here, but something matching or similar to its functionality would be excellent.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.