facebook / facebook/astryx

Spinner: default assistive label bypasses the translation runtime

Open
#6,214 0 comments 1 reaction 0 assignees View on GitHub
accessibility bug i18n
Dominant language
TypeScript
Stars
13k
Forks
1.1k
Avg merge
1d 15h
Merged PRs (30d)
690

Description

## Description

`Spinner` supplies the assistive-technology-facing default label `"Loading"` directly in component source instead of obtaining it from the Astryx translation runtime.

A localized application that relies on the default cannot translate the status. AT-facing text follows the same localization requirement as visible text. The default needs a catalog-backed translation path while preserving an explicit consumer `aria-label` override.

## Reproduction

1. Render `` inside an `InternationalizationProvider` using a non-English locale.
2. Inspect the Spinner accessible name.
3. Observe `"Loading"` in English.
4. Search `Spinner.tsx`; the default is a literal string rather than a translator key.

## Astryx Version

Current `main` (`@astryxdesign/core@0.5.4`).

## Environment

Chrome on macOS; DOM and source inspection.

Related: #3636

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.