facebook / facebook/astryx

XDSText: should the default "display" value be "block"?

Open
#2,890 2 comments 0 reactions 0 assignees View on GitHub
component discussion
Dominant language
TypeScript
Stars
13k
Forks
1.1k
Avg merge
1d 15h
Merged PRs (30d)
690

Description

## Question / Discussion

Should the default value for the `display` property on `XDSText` be **`block`**?

Most text elements are intended to be used as block-level elements, so defaulting `display` to `block` may better match common usage.

## Open question
- Would changing the default `display` value to `block` be a beneficial change?
- Are there common use cases where a non-block default is preferable (e.g. inline text within a sentence) that would make this a breaking or undesirable change?

## Related: `size` vs `type`
It appears that the `size` property for `XDSText` does **not** override the `type` property.

- Confirm whether this is actually the case (i.e. `size` is being ignored when `type` is set).
- Decide whether `size` overriding `type` is a behavior we want to support.

## Component
- `XDSText`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.