facebook / facebook/TestSlide

Add constructor input checks for matchers

Open
#233 0 comments 0 reactions 1 assignee Claimed by @deathowl View on GitHub
enhancement Hacktoberfest
Dominant language
Python
Stars
149
Forks
62
PR merge metrics
No merged PRs in 30d

Description

When we do:

```
AnyInstanceOf(not_a_type)
```

we end up raising an exception **not** at the constructor, but rather when the comparison is being made, and `isinstanceof` (at `AnyInstanceOf`'s code) will complain that `not_a_type` is... not a type.

Let's revisit all matchers & ensure that all of them raise `ValueError` if the constructor arguments are invalid from the constructor itself.

CC @deathowl

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.