f / f/delorean

Doesn't work with Require.js

Open
#72 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
749
Forks
38
PR merge metrics
No merged PRs in 30d

Description

The bower distributed delorean does not work with Require.js

First problem is `require('events').EventEmitter`:

```
module.exports = requirements = {
// DeLorean uses **Node.js native EventEmitter** for event emittion
EventEmitter: require('events').EventEmitter,
// and **es6-promise** for Deferred object management.
Promise: require('es6-promise').Promise
};
```

But the module is defined as:

```
module.exports = EventEmitter
```

So I think in the injector it should just be `require('event')` right?

Second problem is in the injector:

```
// This library needs to work for Browserify and also standalone.
// If DeLorean is defined, it means it's called from the browser, not
// the browserify.
if (typeof DeLorean !== 'undefined') {
for (var requirement in requirements) {
DeLorean.Flux.define(requirement, requirements[requirement]);
}
}
```

But when used in the browser with Require.js, DeLorean _is_ `undefined` because:

```
if (typeof define === 'function' && define.amd) {
define([], function () {
return DeLorean;
});
} else {
window.DeLorean = DeLorean;
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.