f-dangel / f-dangel/singd

Improve efficiency of `_extract_patches` function

Open
#53 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
24
Forks
0
PR merge metrics
No merged PRs in 30d

Description

We might be able to implement [`_extract_patches`](https://github.com/f-dangel/singd/blob/main/singd/optim/utils.py#L12-L40) more efficiently for some special cases, e.g.
- when `dilation=1`, we can look into using something like the [`im2col_2d`](https://github.com/kazukiosawa/asdl/blob/master/asdl/utils.py#L51-L71) function in ASDL (if indeed faster);
- when using KFAC-reduce, we should be using Felix's implementation in `einconv`, see the corresponding [paper](https://arxiv.org/abs/2307.02275).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.