f-dangel / f-dangel/singd

Bug: Mismatch with Lin 2023 implementation for `'sum'` reduction

Open
#43 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
24
Forks
0
PR merge metrics
No merged PRs in 30d

Description

I parameterized the test that compares with the Lin 2023 implementation with reductions `'mean'` and `'sum'`. For `reduction='sum'`, our implementation differs from Lin 2023. See the [`bug-reduction-sum`](https://github.com/f-dangel/singd/tree/bug-reduction-sum) branch to re-produce this bug.

At the moment, I haven't done any debugging to narrow down the cause of this bug.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.