f-dangel / f-dangel/singd

Deprecate `.from_inner2` from `StructuredMatrix` interface

Open
#37 0 comments 0 reactions 0 assignees View on GitHub
discussion enhancement
Dominant language
Python
Stars
24
Forks
0
PR merge metrics
No merged PRs in 30d

Description

We originally incorporated this function to support updates based `K.T @ (a @ a.T) @ K` and `K.T @ (g @ g.T) @ K`, e.g. in the private ASDL implementation.

But now we are using an update that computes `(K.T @ a) (K.T @ a).T` and `(K.T @ g) @ (K.T @ g).T` instead via `StructuredMatrix.from_inner`. Hence, we can remove `from_inner2` and the associated tests.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.