Remove ref assignment
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 3.4k
- Forks
- 361
- Avg merge
- 3d 41m
- Merged PRs (30d)
- 2
Description
This is more of a feature request. We're migrating our app from PHP 5.5 => PHP 7+ and are checking if we use incompatible libraries. While running a search for changed variable handling we found the following line in this library: https://github.com/ezyang/htmlpurifier/blob/a93250f251350e306494af1ac3678d2cd36861d7/library/HTMLPurifier/HTMLModule/Tidy.php#L150
This is a false positive since it's commented but the weird reference assignment could be fixed if you read http://php.net/manual/en/migration70.incompatible.php#migration70.incompatible.variable-handling.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open library/HTMLPurifier/HTMLModule/Tidy.php at line 150 and inspect the commented reference assignment in the context of PHP 7 variable-handling changes. Remove the obsolete reference assignment, with completion indicated when the false-positive migration search no longer flags that line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100