ezyang / ezyang/htmlpurifier

Admit whitespace-only attribute values

Open
#204 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
3.4k
Forks
361
Avg merge
3d 41m
Merged PRs (30d)
2

Description

Attributes are trimmed down by default. I understand this is a desirable behavior in regard to cleaning content, but this doesn't allow for explicitly whitespace-only attributes (e.g. https://www.w3.org/Math/testsuite/mml2-testsuite/Presentation/GeneralLayout/mfenced/mfencedAempty.xml). Is there some way around this for specific cases that doesn't interfere with the general expected behavior of trimming?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is identified in the issue. Start by locating the attribute-trimming behavior and the MathML handling related to the linked mfenced example; done means whitespace-only attribute values can be admitted for specific cases without changing the default trimming behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.