ezyang / ezyang/htmlpurifier

feature-request : use other allowed units for Length

Open
#147 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
3.4k
Forks
361
Avg merge
3d 41m
Merged PRs (30d)
2

Description

I would like to use other unit for my style property like 'rem' or 'vh' but they're not valid according to library/HTMLPurifier/Length::$allowedUnits

Is it possible to add them directly or allow us to use any other type of unit ?

Thank you

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review library/HTMLPurifier/Length::$allowedUnits and trace how style length values are validated. Determine whether the requested units should be added explicitly or accepted through a configurable rule; done means the selected behavior is implemented and verified for rem and vh.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, php
Domain
security, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.