ezyang / ezyang/htmlpurifier

Implement sip URI scheme

Open
#142 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
3.4k
Forks
361
Avg merge
3d 41m
Merged PRs (30d)
2

Description

Just like https://github.com/ezyang/htmlpurifier/pull/87 did for 'tel' but for then for the proposed standard 'sip'.

Use case: our customer asks to allow the 'sip' protocol so she can make links that can be handled by Skype for business.

Todo:

  • add 'sip' to library/HTMLPurifier/ConfigSchema/schema/URI.AllowedSchemes.txt
  • add library/HTMLPurifier/URIScheme/sip.php that validates according to 'sip's proposed standard https://tools.ietf.org/html/rfc3261
  • add test coverage

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with library/HTMLPurifier/ConfigSchema/schema/URI.AllowedSchemes.txt and the existing URI scheme implementation referenced by the tel pull request. Read RFC 3261 and add the requested library/HTMLPurifier/URIScheme/sip.php validation, then add test coverage. Done means sip is allowed only when it passes the proposed standard's validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.