ezyang / ezyang/ghstack

Make ghstack land work with protected master branch

Open
#50 15 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

high priority
Dominant language
Python
Stars
1k
Forks
84
PR merge metrics
No merged PRs in 30d

Description

ghstack land directly pushes to master, which means that if master is protected, you can't use it. It would be nice to figure out some way to work around this.

One silly way to do it is to open a NEW pr that is based on master, and then use GitHub API to merge it. However, if you have mandatory checks on a project, you have to wait for all the checks to finish before you can merge. Another possibility is to get a bot with push to protected rights and teach ghstack to ask that bot to do the merge.

cc @fmassa

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the ghstack land entry point and its interaction with the GitHub API. Compare the proposed new-PR and bot-based approaches against protected master branches and mandatory checks. Done means one supported approach is implemented with clear behavior for protected branches and checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.