ezyang / ezyang/ghstack

Add 'ghstack pull'

Open
#28 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1k
Forks
84
PR merge metrics
No merged PRs in 30d

Description

Right now, if someone updated a ghstack PR, and then you try to push to it without updating first, ghstack will just error out. If we supported ghstack pull that would result in a Git merge that would be better. We can just do the merge on the synthetic head branches, and then recreate a correct orig commit after it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the existing ghstack push flow and the handling of synthetic head branches and orig commits. Done means ghstack pull can merge updates from an existing ghstack PR and recreate the correct orig commit without the current push failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, python
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.