submit --force doesn't make all pushes force-pushes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 84
- PR merge metrics
- No merged PRs in 30d
Description
Through some sort of github user error (probably mine), a bunch of extra commits got added to one of my stacked PRs recently. I couldn't rebase and rerun ghstack --direct because the branches were out of sync. I was baffled as to why --force didn't resolve my issue, but it looks like it does something different? If this is an oversight, it could be fixed by adding force=self.force on https://github.com/ezyang/ghstack/blob/6f32174e56e3b1f783d03a7ed02d97a6f9a78aa7/ghstack/submit.py#L1533 and https://github.com/ezyang/ghstack/blob/6f32174e56e3b1f783d03a7ed02d97a6f9a78aa7/ghstack/submit.py#L1535 .
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ghstack/submit.py at the two push calls around lines 1533 and 1535, and trace how the submit --force option is passed into them. Confirm that every push performed by submit receives the force setting, then verify that --force makes all pushes force-pushes using the relevant existing test or command workflow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100