`ghstack submit --update-fields` created a new pull request if the ghstack info is damaged or missing
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 84
- PR merge metrics
- No merged PRs in 30d
Description
This might not be expected behavior. Two other possibilities are that ghstack submit --update-fields fails if the ghstack info in the commit message is damaged or missing, or to create another flag --update-only/-U, with this behavior.
I'd be willing to submit a pull request for either one of these behaviors if there were interest.
This happened when I restored my ghstack info from a branch as:
ghstack-source-id: de78c83d0763391c27c41501f614fafd49c9395c
Pull Request resolved: #128416
instead of
ghstack-source-id: de78c83d0763391c27c41501f614fafd49c9395c
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128416
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ghstack submit --update-fields entry point and reproduce the case with a damaged or missing Pull Request resolved value in the commit message. Review how the command handles the shown URL form versus the numeric form; done requires an agreed behavior, either failing safely or updating only an existing pull request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, python
- Domain
- cli, devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100