--no-skip doesn't work anymore
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 84
- PR merge metrics
- No merged PRs in 30d
Description
I was seeing ghstack skip some PRs that I wanted to update, so I tried running --no-skip on ghstack 0.9.3, but it still skipped the PRs. From a quick look through the code, it looks like maybe --no-skip support was removed by accident when reworking the code for 0.9.0.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ghstack's command-line handling for --no-skip and the PR-skipping path in version 0.9.3, then compare the 0.9.0 rework. Confirm that --no-skip causes selected PRs to be updated rather than skipped, and add or run a regression test if the repository provides one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100