ezyang / ezyang/ghstack

Problem when tree doesn't change but commit structure has changed

Open
#123 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

high priority
Dominant language
Python
Stars
1k
Forks
84
PR merge metrics
No merged PRs in 30d

Description

Suppose you have commit A and B. You squash them into AB and run ghstack. This won't work; ghstack will say "well, B has the same tree as AB, so there's nothing to do." Even worse, when you're done, it will re check out B, undoing your AB merge.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the A/B squash scenario described in the issue by running ghstack and observing the identical-tree check and subsequent checkout. Trace the commit comparison and checkout entry points, then verify that a changed commit structure is handled without undoing the squashed AB result.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, python
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.