ezyang / ezyang/ghstack

Why can't the base of the stack be the actual main branch?

Open
#122 13 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

high priority
Dominant language
Python
Stars
1k
Forks
84
PR merge metrics
No merged PRs in 30d

Description

This is more of question. The README page correctly points out that merging commits from the github UI becomes impossible when using ghstack. One thing that would help with this is if the actual base of the branch the real main and not a brach created by ghstack. I am sure there is a reason for it but why is the base branch called gh/username/1/base, what would be the downside of basing the PR against main?

WARNING. You will NOT be able to merge these commits using the normal GitHub UI, as their branch bases won't be master. Use ghstack land $PR_URL to land a ghstack'ed pull request.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the README section containing the GitHub UI warning and trace how ghstack creates gh/username/1/base and lands stacked pull requests. Read the issue discussion for the stated constraints around using main; done means documenting the reason and determining whether changing the base is viable.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.