expressjs / expressjs/morgan

Adding a token named token causes all subsequent tokens to break.

Open
#265 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
8.2k
Forks
565
Avg merge
3d 2h
Merged PRs (30d)
12

Description

This works just fine:
```js
var logger = require('morgan');
logger.token('ip', function (req, res) { return req.ip ? req.ip : "" });
logger.token('uuid', function (req, res) { return (req.token ? req.token.uuid : "") });
logger.token('token', function (req, res) { return (req.token ? req.token.token : "") });
```
This gives "TypeError: tokens.uuid is not a function" when called in the logger:
```js
var logger = require('morgan');
logger.token('ip', function (req, res) { return req.ip ? req.ip : "" });
logger.token('token', function (req, res) { return (req.token ? req.token.token : "") });
logger.token('uuid', function (req, res) { return (req.token ? req.token.uuid : "") });
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.