expressjs / expressjs/discussions

Discussion: Using engines in the package.json

Open
#286 29 comments 0 reactions 1 assignee Claimed by @UlisesGascon View on GitHub
discuss
Dominant language
No language data
Stars
73
Forks
25
PR merge metrics
No merged PRs in 30d

Description

Currently some packages has drop support to Node.js prior to v18, seems like we didn't upgrade the engines field in the `package.json` discordantly.

So, I will like to discuss if this a policy that we should follow as an organization to all the packages (so in that case we can also document it).

:warning: So far seems like Express actually updated the package ([ref](https://github.com/expressjs/express/blob/master/package.json#L83)) but not in others like finalhandler ([ref](https://github.com/pillarjs/finalhandler/blob/master/package.json#L38))

Ref:
- https://github.com/pillarjs/finalhandler/issues/64
- https://github.com/pillarjs/finalhandler/pull/59 (great context on why not update by @wesleytodd )

cc: @expressjs/express-tc @Phillip9587

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.