expressjs / expressjs/compression

callback parameter is missing from 'write' and 'end' methods

Open
#46 14 comments 1 reaction 1 assignee Claimed by @bjohansebas View on GitHub
bug
Dominant language
JavaScript
Stars
2.8k
Forks
255
Avg merge
3d 15h
Merged PRs (30d)
3

Description

The methods 'write' and 'end' don't accept a 'callback' parameter - the underlaying http response stream does. Therefore there is a different runtime behaviour when sending off the data in chunks (waiting for the response to be written) when using compression (callback will not be called and the program hangs)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.