expressjs / expressjs/body-parser

Are our tests reliable?

Open
#592 3 comments 1 reaction 0 assignees View on GitHub
discuss
Dominant language
JavaScript
Stars
5.5k
Forks
767
Avg merge
13h 53m
Merged PRs (30d)
10

Description

We use supertest to run our tests in this module. While that tool does a great job, I'm not sure if we're making reliable tests, since Supertest also handles the body according to the `content-type`, which makes me question whether we're doing good tests or if in the future the tests will stop being reliable as we update that dependency.

Ref: https://github.com/ladjs/superagent/pull/1812

cc: @Phillip9587, @jonchurch, @wesleytodd, @UlisesGascon

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.